feat: add stats tracking for pacote.extract #618
Conversation
🦋 Changeset detectedLatest commit: e985c9f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workspaces/scanner/src/depWalker.ts
Outdated
| spec, | ||
| registry | ||
| registry, | ||
| extractFn |
There was a problem hiding this comment.
i would just inline the operation and rename the extractFn to pacoteProvider:
{
pacoteProvider:(spec: string, dest: string, opts: pacote.Options) => statsCollector.track(
`pacote.extract ${spec}`,
() => pacote.extract(spec, dest, opts)
)
}
workspaces/tarball/src/tarball.ts
Outdated
| }; | ||
| } | ||
|
|
||
| type ExtractFunction = ( |
There was a problem hiding this comment.
i would rename it PacoteProvider and use an interface with the method extract
workspaces/scanner/src/depWalker.ts
Outdated
| ref: any; | ||
| statsCollector: StatsCollector; | ||
| extractFn?: (spec: string, dest: string, opts: pacote.Options) => Promise<void>; | ||
| pacoteProvider?: import("@nodesecure/tarball").PacoteProvider; |
There was a problem hiding this comment.
It’s more readable to import the type at the top of the file
workspaces/scanner/src/depWalker.ts
Outdated
| pacoteProvider: { | ||
| extract: async(spec: string, dest: string, opts: pacote.Options) => { | ||
| await statsCollector.track( | ||
| `pacote.extract[${spec}]`, |
There was a problem hiding this comment.
pacote.extract[${spec}] -> pacote.extract ${spec}
It’s the same pattern in the two other examples
workspaces/scanner/src/depWalker.ts
Outdated
| registry, | ||
| statsCollector, | ||
| extractFn: trackedExtract | ||
| pacoteProvider: { |
There was a problem hiding this comment.
We should probably just build the the object once and reuse the same, and not building a new one for each scan
7amed3li
force-pushed
the
feat/stats-tracking-pacote-extract
branch
from
02daaed to
3483f28
Compare
workspaces/scanner/src/depWalker.ts
Outdated
|
|
||
| const pacoteProvider: PacoteProvider = { | ||
| extract: async(spec, dest, opts) => { | ||
| await statsCollector.track( |
There was a problem hiding this comment.
You don’t need the async await syntax since you don’t need the awaited result in this function
2 participants
This PR adds lightweight stats tracking for
pacote.extractby injecting a tracked extract function.This helps identify slow package extractions and potential bottlenecks during scans.
No breaking changes - existing code works as-is.
Closes #615